c-variadic: bpf and spirv do not support c-variadic definitions #149557
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
|
folkertdev
force-pushed
the
c-variadic-not-supported
branch
from
2af7dca to
1f9013b
Compare
Urgau
reviewed
Dec 2, 2025
folkertdev
force-pushed
the
c-variadic-not-supported
branch
from
1f9013b to
80a780f
Compare
Collaborator
|
These commits modify compiler targets. |
folkertdev
force-pushed
the
c-variadic-not-supported
branch
from
80a780f to
695d2fa
Compare
folkertdev
commented
Dec 3, 2025
Comment on lines
1936
to
1938
| // We don't know if the target supports c-variadic definitions, but we don't want | ||
| // to needlesly restrict custom target.json configurations. | ||
| Other(_) => true, |
Contributor
Author
There was a problem hiding this comment.
This is kind of up for debate, but a custom target.json is kind of "here be dragons" already, and if the new target gets proper compiler support a choice still has to be made here.
| variadic_span: variadic_param.span, | ||
| target: &*self.sess.target.llvm_target, | ||
| }); | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
emitting other errors here doesn't seem useful when the target just does not support c-variadics.
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
c-variadic-not-supported
branch
from
695d2fa to
fe1855e
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
c-variadic-not-supported
branch
from
fe1855e to
fc017dd
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #44930
Emit a nice error message on bpf and spirv targets when a c-variadic function is defined. Spirv also does not support c-variadic calls, bpf appears to allow them.
r? @workingjubilee